Compositor Animation Timelines: Fix frame swapping tests in WebFrameTest.cpp

third_party/WebKit/Source/web/WebFrame.cpp

Index: third_party/WebKit/Source/web/WebFrame.cpp
diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp
index 5479891ff3c8cfbf84a641131ada03b3a44981ef..f20483340d86e280234b494bd148408021b12811 100644
--- a/third_party/WebKit/Source/web/WebFrame.cpp
+++ b/third_party/WebKit/Source/web/WebFrame.cpp
@@ -90,6 +90,9 @@ bool WebFrame::swap(WebFrame* frame)
     oldFrame->windowProxyManager()->clearForNavigation();
     oldFrame->windowProxyManager()->releaseGlobals(globals);
 
+    if (oldFrame->isMainFrame())
+        oldFrame->page()->willSwapMainFrame(toCoreFrame(frame));
+
     // Although the Document in this frame is now unloaded, many resources
     // associated with the frame itself have not yet been freed yet.
     oldFrame->detach(FrameDetachType::Swap);

[aelias_OOO_until_Jul13, 2015/11/19 01:19:58]

Please plumb it from this detach() method instead.  It already knows it's a
swap-type detach from the enum passed in here, and you're not using the argument
you passed in for the new frame.

[loyso (OOO), 2015/11/19 03:55:00]

Done.

[loyso (OOO), 2015/11/19 03:59:32]

p.s. WebFrame::detach is already called from Page::willBeDestroyed. So, calling
something back is strange in terms of ownership.