Compositor Animation Timelines: Fix frame swapping tests in WebFrameTest.cpp

third_party/WebKit/Source/web/WebFrame.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "public/web/WebFrame.h"
 
 #include "bindings/core/v8/WindowProxyManager.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/FrameView.h"
@@ skipping 72 matching lines @@
     FrameHost* host = oldFrame->host();
     AtomicString name = oldFrame->tree().name();
     FrameOwner* owner = oldFrame->owner();
     oldFrame->disconnectOwnerElement();
 
     v8::HandleScope handleScope(v8::Isolate::GetCurrent());
     HashMap<DOMWrapperWorld*, v8::Local<v8::Object>> globals;
     oldFrame->windowProxyManager()->clearForNavigation();
     oldFrame->windowProxyManager()->releaseGlobals(globals);
 
+    if (oldFrame->isMainFrame())
+        oldFrame->page()->willSwapMainFrame(toCoreFrame(frame));
+
     // Although the Document in this frame is now unloaded, many resources
     // associated with the frame itself have not yet been freed yet.
     oldFrame->detach(FrameDetachType::Swap);

[aelias_OOO_until_Jul13, 2015/11/19 01:19:58]

Please plumb it from this detach() method instead.  It already knows it's a
swap-type detach from the enum passed in here, and you're not using the argument
you passed in for the new frame.

[loyso (OOO), 2015/11/19 03:55:00]

Done.

[loyso (OOO), 2015/11/19 03:59:32]

p.s. WebFrame::detach is already called from Page::willBeDestroyed. So, calling
something back is strange in terms of ownership.

 
     // Finally, clone the state of the current Frame into one matching
     // the type of the passed in WebFrame.
     // FIXME: This is a bit clunky; this results in pointless decrements and
     // increments of connected subframes.
     if (frame->isWebLocalFrame()) {
         LocalFrame& localFrame = *toWebLocalFrameImpl(frame)->frame();
         ASSERT(owner == localFrame.owner());
         if (owner) {
             if (owner->isLocal()) {
@@ skipping 257 matching lines @@
     void WebFrame::traceFrames(VisitorDispatcher visitor, WebFrame* frame) { traceFramesImpl(visitor, frame); }                \
     void WebFrame::clearWeakFrames(VisitorDispatcher visitor) { clearWeakFramesImpl(visitor); }
 
 DEFINE_VISITOR_METHOD(Visitor*)
 DEFINE_VISITOR_METHOD(InlinedGlobalMarkingVisitor)
 
 #undef DEFINE_VISITOR_METHOD
 #endif
 
 } // namespace blink