Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1458963005: build: Fix Clang build when passing order_profiling==1. (Closed)

Created:
5 years, 1 month ago by pcc1
Modified:
5 years ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build: Fix Clang build when passing order_profiling==1. Clang doesn't understand -finstrument-functions-exclude-file-list=, but nor does it need it, so disable those flags under Clang. Depends on https://codereview.chromium.org/1456173004 BUG=539408 R=thakis@chromium.org Committed: https://crrev.com/b114a7eb6b8f6cd305b0de9ae67cf69e5b5f2878 Cr-Commit-Position: refs/heads/master@{#362216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/common.gypi View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
pcc1
5 years, 1 month ago (2015-11-19 04:32:23 UTC) #1
Nico
lgtm
5 years, 1 month ago (2015-11-19 05:06:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458963005/1
5 years, 1 month ago (2015-11-19 21:09:44 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/125591) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 1 month ago (2015-11-19 21:13:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458963005/1
5 years, 1 month ago (2015-11-20 00:40:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios_rel_device_ninja on ...
5 years, 1 month ago (2015-11-20 02:45:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458963005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458963005/1
5 years ago (2015-11-30 18:52:40 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-30 20:50:08 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-30 20:50:56 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b114a7eb6b8f6cd305b0de9ae67cf69e5b5f2878
Cr-Commit-Position: refs/heads/master@{#362216}

Powered by Google App Engine
This is Rietveld 408576698