Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issue 1456173004: wtf: Eliminate inliner abuse in saturatedSet function. (Closed)

Created:
5 years, 1 month ago by pcc1
Modified:
5 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wtf: Eliminate inliner abuse in saturatedSet function. The two overloads of the saturateSet function previously took an argument, FractionalShift, of type int, which they passed to an inline asm block using an "n" (integer immediate) constraint. This meant that the function could not be compiled on its own if its address was taken (either directly or via e.g. -finstrument-functions), as FractionalShift would not be a constant. Fix this by passing FractionalShift as a template parameter. This lets us remove its header file from the -finstrument-functions blacklist. BUG=539408 R=thakis@chromium.org Committed: https://crrev.com/3f68f09657fbab2d69bd253f163c8c1ec08d9759 Cr-Commit-Position: refs/heads/master@{#360696}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -22 lines) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/LayoutUnit.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/SaturatedArithmetic.h View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/SaturatedArithmeticTest.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/wtf/asm/SaturatedArithmeticARM.h View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
pcc1
5 years, 1 month ago (2015-11-19 04:32:19 UTC) #1
Nico
Huh, so this only compiled by accident 'cause this function was inlined at every call ...
5 years, 1 month ago (2015-11-19 05:06:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456173004/1
5 years, 1 month ago (2015-11-19 21:09:42 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
5 years, 1 month ago (2015-11-19 23:15:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456173004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456173004/1
5 years, 1 month ago (2015-11-19 23:19:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-20 00:33:36 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 00:34:37 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f68f09657fbab2d69bd253f163c8c1ec08d9759
Cr-Commit-Position: refs/heads/master@{#360696}

Powered by Google App Engine
This is Rietveld 408576698