Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1458913005: option to quick-accept clipRect calls (Closed)

Created:
5 years, 1 month ago by reed1
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

option to quick-accept clipRect calls BUG=skia: Committed: https://skia.googlesource.com/skia/+/90ba095c459e38581353073826785074b5953b8c

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : shared call into maprect #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M src/core/SkCanvas.cpp View 1 2 1 chunk +33 lines, -13 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
reed1
ptal
5 years, 1 month ago (2015-11-19 22:01:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458913005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458913005/20001
5 years, 1 month ago (2015-11-19 22:01:37 UTC) #4
robertphillips
lgtm % todo re sharing xform work
5 years, 1 month ago (2015-11-19 22:12:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458913005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458913005/40001
5 years, 1 month ago (2015-11-20 18:15:52 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/90ba095c459e38581353073826785074b5953b8c
5 years, 1 month ago (2015-11-20 21:42:52 UTC) #10
bsalomon
5 years, 1 month ago (2015-11-21 02:52:54 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1471513002/ by bsalomon@google.com.

The reason for reverting is: Breaking tests on Android:

D/skia    ( 4469): 
D/skia    ( 4469): Failures:
D/skia    ( 4469):
	../../../tests/CanvasStateTest.cpp:325	clipStackBounds.width() == WIDTH
D/skia    ( 4469):
	../../../tests/CanvasStateTest.cpp:326	clipStackBounds.height() == HEIGHT
D/skia    ( 4469): 2 failures

http://build.chromium.org/p/client.skia.android/builders/Test-Android-GCC-Nex....

Powered by Google App Engine
This is Rietveld 408576698