Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1458753003: Drop [TreatNullAs=NullString] for Document.cookie (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Drop [TreatNullAs=NullString] for Document.cookie https://html.spec.whatwg.org/#document After this change, setting document.cookie to null will stringify to "null", so it's simply like setting a cookie by that name. This matches Firefox Nightly and Edge. BUG=497307 Committed: https://crrev.com/b05426e99566190787f9532e9af0e8cdf7c1dd9b Cr-Commit-Position: refs/heads/master@{#360567}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
A + third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null.html View 1 chunk +4 lines, -7 lines 0 comments Download
A + third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null-expected.txt View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458753003/1
5 years, 1 month ago (2015-11-18 13:48:22 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/142438)
5 years, 1 month ago (2015-11-18 14:56:36 UTC) #4
philipj_slow
PTAL and CQ? I think that linux_chromium_rel_ng is flaky, not my failures.
5 years, 1 month ago (2015-11-18 15:27:39 UTC) #6
philipj_slow
Ping? You've posted reviews so I know you're there ;)
5 years, 1 month ago (2015-11-19 09:18:37 UTC) #7
Mike West
Sorry, I missed this. :/ LGTM, matches the spec and everything. Perhaps add a link ...
5 years, 1 month ago (2015-11-19 09:43:15 UTC) #8
philipj_slow
On 2015/11/19 09:43:15, Mike West wrote: > Sorry, I missed this. :/ > > LGTM, ...
5 years, 1 month ago (2015-11-19 12:09:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458753003/1
5 years, 1 month ago (2015-11-19 12:10:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 12:54:03 UTC) #13
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 12:55:40 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b05426e99566190787f9532e9af0e8cdf7c1dd9b
Cr-Commit-Position: refs/heads/master@{#360567}

Powered by Google App Engine
This is Rietveld 408576698