Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null.html

Issue 1458753003: Drop [TreatNullAs=NullString] for Document.cookie (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/cookies/http-get-cookie-set-in-js.html b/third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null.html
similarity index 59%
copy from third_party/WebKit/LayoutTests/http/tests/cookies/http-get-cookie-set-in-js.html
copy to third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null.html
index ab8eb4d8bfc97424d86320e242e6b7a578f85ae6..4216bef72baee5cd74d93f8602e7f0cf0ddef25c 100644
--- a/third_party/WebKit/LayoutTests/http/tests/cookies/http-get-cookie-set-in-js.html
+++ b/third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null.html
@@ -8,16 +8,13 @@
<p id="description"></p>
<div id="console"></div>
<script>
-description(
-'Test that a cookie set using JavaScript can be correctly read by HTTP server'
-);
+description("Setting document.cookie to null should set a cookie named 'null'");
clearAllCookies();
-document.cookie = "name=value;Max-Age=1000";
-
-debug('checking that the cookie set in javascript can be read by HTTP server');
-testCookies("name=value");
+document.cookie = null;
+shouldBe("document.cookie", "'null'");
+testCookies("null");
clearCookies();
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/cookies/js-set-null-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698