Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp

Issue 1458733002: Fix CSS outline property in flipped blocks Writing Mode (vertical-rl) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: !isBox() Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
index db014c3d21e672396f0aece1f09266c5d7fa0911..34c0b0792f4ba35358b9df99ac1b8106c46df1f8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
@@ -449,14 +449,8 @@ void LayoutBoxModelObject::addOutlineRectsForDescendant(const LayoutObject& desc
if (descendant.hasLayer()) {
Vector<LayoutRect> layerOutlineRects;
descendant.addOutlineRects(layerOutlineRects, LayoutPoint(), includeBlockOverflows);
- for (size_t i = 0; i < layerOutlineRects.size(); ++i) {
- FloatQuad quadInBox = toLayoutBoxModelObject(descendant).localToContainerQuad(FloatQuad(FloatRect(layerOutlineRects[i])), this);
- LayoutRect rect = LayoutRect(quadInBox.boundingBox());
- if (!rect.isEmpty()) {
- rect.moveBy(additionalOffset);
- rects.append(rect);
- }
- }
+ descendant.localToContainerRects(layerOutlineRects, this, LayoutPoint(), additionalOffset);
+ rects.appendVector(layerOutlineRects);
return;
}
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698