chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js - Issue 1458723002: Finish implementing ChromeVox Next active indicator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js

Issue 1458723002: Finish implementing ChromeVox Next active indicator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_key_map

Patch Set: Made test expectations approximate Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js

index 02c6aee93dd07b7cc345a8e68ee7d78228d75727..7b25b2acbe3164aa8e9b861602671190e6435b62 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js

@@ -35,6 +35,7 @@ BaseAutomationHandler = function(node) {

loadComplete: this.onLoadComplete,

menuStart: this.onEventDefault,

menuEnd: this.onEventDefault,

+ scrollPositionChanged: this.onScrollPositionChanged,

textChanged: this.onTextOrTextSelectionChanged,

textSelectionChanged: this.onTextOrTextSelectionChanged,

valueChanged: this.onValueChanged

@@ -114,11 +115,20 @@ BaseAutomationHandler.prototype = {

* @param {Object} evt

onLoadComplete: function(evt) {},

+ /**

+ * @param {Object} evt

+ */

onEventDefault: function(evt) {},

/**

* @param {Object} evt

+ onScrollPositionChanged: function(evt) {},

+ /**

+ * @param {Object} evt

+ */

onTextOrTextSelectionChanged: function(evt) {},

/**