chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js - Issue 1458723002: Finish implementing ChromeVox Next active indicator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

Issue 1458723002: Finish implementing ChromeVox Next active indicator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_key_map

Patch Set: Made test expectations approximate Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/common/chrome_extension_externs.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

index f38f7071b783b22e7fb106e627359b517d0ec1ec..c0a162884c9aca75fffc7a26fd79057e1729e4d6 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js

@@ -149,6 +149,9 @@ Background.prototype = {

return;

this.currentRange_ = value;

+ if (this.currentRange_)

+ this.currentRange_.start.node.makeVisible();

/**

@@ -326,8 +329,8 @@ Background.prototype = {

.onSpeechEnd(function() { continueReading(prevRange); })

.go();

prevRange = this.currentRange_;

- this.currentRange_ =

- this.currentRange_.move(cursors.Unit.NODE, Dir.FORWARD);

+ this.currentRange =

+ this.currentRange.move(cursors.Unit.NODE, Dir.FORWARD);

if (!this.currentRange_ || this.currentRange_.equals(prevRange))

global.isReadingContinuously = false;

@@ -403,7 +406,7 @@ Background.prototype = {

actionNode.focus();

var prevRange = this.currentRange_;

- this.currentRange_ = current;

+ this.currentRange = current;

new Output().withSpeechAndBraille(

this.currentRange_, prevRange, Output.EventType.NAVIGATE)