chrome/common/extensions/api/automation.idl - Issue 1458723002: Finish implementing ChromeVox Next active indicator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/automation.idl

Issue 1458723002: Finish implementing ChromeVox Next active indicator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_key_map

Patch Set: Addressed feedback and added tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js ('K') | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/renderer/extensions/automation_internal_custom_bindings.h » ('j') | chrome/renderer/extensions/automation_internal_custom_bindings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/automation.idl

diff --git a/chrome/common/extensions/api/automation.idl b/chrome/common/extensions/api/automation.idl

index f9037c5878f85f3214f68d1043a126e0fc590f90..89e036a05678b9ce3d6a0129514be899d578e80d 100644

--- a/chrome/common/extensions/api/automation.idl

+++ b/chrome/common/extensions/api/automation.idl

@@ -334,9 +334,16 @@

// The $(ref:automation.StateType)s describing this node.

object state;

- // The rendered location (as a bounding box) of this node within the frame.

+ // The rendered location (as a bounding box) of this node in global

+ // screen coordinates.

automation.Rect location;

+ // Computes the bounding box of a subrange of this node in global screen

+ // coordinates. Returns the same as |location| if range information

Peter Lundblad 2015/11/23 13:39:08 Uber-nit: the standard in this file is one space a

dmazzoni 2015/11/23 17:22:49 Done.

+ // is not available. The start and end indices are zero-based offsets

+ // into the node's "name" string attribute.

+ static automation.Rect boundsForRange(long startIndex, long endIndex);

// The purpose of the node, other than the role, if any.

DOMString description;