chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js - Issue 1458723002: Finish implementing ChromeVox Next active indicator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 1458723002: Finish implementing ChromeVox Next active indicator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load_key_map

Patch Set: Addressed feedback and added tests Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/base_automation_handler.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | chrome/common/extensions/api/automation.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

index d462777555687e16f85209c49200503fda325c5f..9e6e6abd7207bc7151c30e9bce180cb4dd4392cb 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

@@ -252,6 +252,17 @@ DesktopAutomationHandler.prototype = {

/**

+ * Handle updating the active indicator when the document scrolls.

+ * @param {Object} evt

Peter Lundblad 2015/11/23 13:39:08 nit: I think this @param is redundant given overri

dmazzoni 2015/11/23 17:22:49 Done.

+ * @override

+ */

+ onScrollPositionChanged: function(evt) {

+ var currentRange = global.backgroundObj.currentRange;

+ if (currentRange)

+ new Output().withLocation(currentRange, null, evt.type).go();

+ },

+ /**

* Create an editable text handler for the given node if needed.

* @param {Object} node