pkg/compiler/lib/src/cps_ir/share_final_fields.dart - Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/share_final_fields.dart

Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/share_final_fields.dart

diff --git a/pkg/compiler/lib/src/cps_ir/share_final_fields.dart b/pkg/compiler/lib/src/cps_ir/share_final_fields.dart

index 3308c00e2407724b41dfa8258a2de89a87eddbf8..9752a06a7400af5d2c78f8a7258295d3c5f478b4 100644

--- a/pkg/compiler/lib/src/cps_ir/share_final_fields.dart

+++ b/pkg/compiler/lib/src/cps_ir/share_final_fields.dart

@@ -105,8 +105,7 @@ class ShareFinalFields extends TrampolineRecursiveVisitor implements Pass {

var map = fieldValues.putIfAbsent(field, () => <Primitive,Primitive>{});

Primitive existing = map[receiver];

if (existing != null) {

- existing.substituteFor(primitive);

- primitive.destroy();

+ primitive..replaceUsesWith(existing)..destroy();

node.remove();

return next;

}