Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: pkg/compiler/lib/src/cps_ir/scalar_replacement.dart

Issue 1458703007: dart2js cps: Refactor CallExpressions into Primitives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
diff --git a/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart b/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
index 9d5ce4f637721efb4e60085ee4109ad7df48b290..b220847358fc5c4b8bb4ff19531aeb72b37db05c 100644
--- a/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
+++ b/pkg/compiler/lib/src/cps_ir/scalar_replacement.dart
@@ -142,12 +142,12 @@ class ScalarReplacementVisitor extends TrampolineRecursiveVisitor {
GetMutable getter = new GetMutable(variable);
getter.type = getField.type;
getter.variable.parent = getter;
- getter.substituteFor(getField);
+ getField.replaceUsesWith(getter);
replacePrimitive(getField, getter);
deletePrimitive(getField);
} else {
Primitive value = fieldInitialValues[getField.field];
- value.substituteFor(getField);
+ getField.replaceUsesWith(value);
deleteLetPrimOf(getField);
}
} else if (use is SetField && use.object == ref) {
@@ -158,7 +158,7 @@ class ScalarReplacementVisitor extends TrampolineRecursiveVisitor {
SetMutable setter = new SetMutable(variable, value);
setter.variable.parent = setter;
setter.value.parent = setter;
- setter.substituteFor(setField);
+ setField.replaceUsesWith(setter);
replacePrimitive(setField, setter);
deletePrimitive(setField);
} else {
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/remove_refinements.dart ('k') | pkg/compiler/lib/src/cps_ir/share_final_fields.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698