Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/compiler/bytecode-graph-builder.cc

Issue 1458603012: [Interpreter] Add CreateClosure to BytecodeGraphBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Take IV. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/js-operator.cc » ('j') | src/compiler/js-operator.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-graph-builder.cc
diff --git a/src/compiler/bytecode-graph-builder.cc b/src/compiler/bytecode-graph-builder.cc
index 5bb208ce94f7e5d8a2550d24cb9d0a1f4268c29b..ef97af294840e423a696f2477bc135479edb1e7a 100644
--- a/src/compiler/bytecode-graph-builder.cc
+++ b/src/compiler/bytecode-graph-builder.cc
@@ -643,7 +643,15 @@ void BytecodeGraphBuilder::VisitPopContext(
void BytecodeGraphBuilder::VisitCreateClosure(
const interpreter::BytecodeArrayIterator& iterator) {
- UNIMPLEMENTED();
+ Node* accumulator = environment()->LookupAccumulator();
+ Handle<SharedFunctionInfo> shared_info(
+ OpParameter<Handle<SharedFunctionInfo>>(accumulator));
Michael Starzinger 2015/11/20 17:11:43 Not sure what this OpParameter call is trying to a
oth 2015/11/21 14:19:47 A JSCreateClosure node taking a Handle<SharedFunct
+ PretenureFlag pretenure =
+ iterator.GetImmediateOperand(0) ? TENURED : NOT_TENURED;
+ const Operator* op = javascript()->CreateClosure(shared_info, pretenure);
+ Node* closure = NewNode(op);
+ AddEmptyFrameStateInputs(closure);
+ environment()->BindAccumulator(closure);
}
« no previous file with comments | « no previous file | src/compiler/js-operator.cc » ('j') | src/compiler/js-operator.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698