[Interpreter] Add CreateClosure to BytecodeGraphBuilder.

src/compiler/bytecode-graph-builder.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/bytecode-graph-builder.h"
 
 #include "src/compiler/linkage.h"
 #include "src/compiler/operator-properties.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 
@@ skipping 625 matching lines @@
 
 
 void BytecodeGraphBuilder::VisitPopContext(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGraphBuilder::VisitCreateClosure(
     const interpreter::BytecodeArrayIterator& iterator) {
-  UNIMPLEMENTED();
+  Node* accumulator = environment()->LookupAccumulator();
+  Handle<SharedFunctionInfo> shared_info(
+      OpParameter<Handle<SharedFunctionInfo>>(accumulator));

[Michael Starzinger, 2015/11/20 17:11:43]

Not sure what this OpParameter call is trying to achieve, but I am not aware of
any nodes whose parameter is Handle<SharedFunctionInfo>. This won't work.

If the assumption is that the "accumulator" node is a HeapConstant, then please
use a HeapObjectMatcher to access it.

[oth, 2015/11/21 14:19:47]

A JSCreateClosure node taking a Handle<SharedFunctionInfo> argument is
constructed two lines below.

HeapObjectMatcher is a wrapper around OpParameter. One of these is widely used.

+  PretenureFlag pretenure =
+      iterator.GetImmediateOperand(0) ? TENURED : NOT_TENURED;
+  const Operator* op = javascript()->CreateClosure(shared_info, pretenure);
+  Node* closure = NewNode(op);
+  AddEmptyFrameStateInputs(closure);
+  environment()->BindAccumulator(closure);
 }
 
 
 void BytecodeGraphBuilder::VisitCreateMappedArguments(
     const interpreter::BytecodeArrayIterator& iterator) {
   UNIMPLEMENTED();
 }
 
 
 void BytecodeGraphBuilder::VisitCreateUnmappedArguments(
@@ skipping 571 matching lines @@
 
 void BytecodeGraphBuilder::UpdateControlDependencyToLeaveFunction(Node* exit) {
   if (environment()->IsMarkedAsUnreachable()) return;
   environment()->MarkAsUnreachable();
   exit_controls_.push_back(exit);
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8