Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Issue 1458583003: ability to build d8 w/ post-mortem data (Closed)

Created:
5 years, 1 month ago by ofrobots
Modified:
5 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ability to build d8 w/ post-mortem data post-mortem data can be useful for debugging, specially with the new llnode [1] extensions for lldb. [1] https://github.com/indutny/llnode R=yangguo@chromium.org BUG= Committed: https://crrev.com/db867c2bd8db3a1f287caced52a6084a5a1c6ec5 Cr-Commit-Position: refs/heads/master@{#32092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/d8.gyp View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ofrobots
5 years, 1 month ago (2015-11-17 22:28:11 UTC) #1
Yang
On 2015/11/17 22:28:11, ofrobots wrote: lgtm.
5 years, 1 month ago (2015-11-18 06:41:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458583003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458583003/1
5 years, 1 month ago (2015-11-18 15:28:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-18 15:55:35 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 15:55:55 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db867c2bd8db3a1f287caced52a6084a5a1c6ec5
Cr-Commit-Position: refs/heads/master@{#32092}

Powered by Google App Engine
This is Rietveld 408576698