Issue 1458523002: Add LDR/LDRB (register) to ARM integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1458523002: Add LDR/LDRB (register) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl

Modified:
5 years, 1 month ago

Reviewers:
Jim Stichnoth, sehr, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+178 lines, -32 lines)			Patch
M	src/IceAssemblerARM32.cpp	View	4 chunks	+88 lines, -31 lines	0 comments	Download
M	src/IceInstARM32.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests_lit/assembler/arm32/ldr-shift.ll	View	1 chunk	+89 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Karl

5 years, 1 month ago (2015-11-17 22:02:08 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cdb3ed6870ef03215a8d6ed977d8ed0e4bc328a5 (presubmit successful).