Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 1458523002: Add LDR/LDRB (register) to ARM integrated assembler. (Closed)

Created:
5 years, 1 month ago by Karl
Modified:
5 years, 1 month ago
Reviewers:
Jim Stichnoth, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -32 lines) Patch
M src/IceAssemblerARM32.cpp View 4 chunks +88 lines, -31 lines 0 comments Download
M src/IceInstARM32.h View 1 chunk +1 line, -1 line 0 comments Download
A tests_lit/assembler/arm32/ldr-shift.ll View 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Karl
5 years, 1 month ago (2015-11-17 18:54:03 UTC) #3
Jim Stichnoth
lgtm
5 years, 1 month ago (2015-11-17 20:42:29 UTC) #4
Karl
5 years, 1 month ago (2015-11-17 22:02:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cdb3ed6870ef03215a8d6ed977d8ed0e4bc328a5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698