src/IceInstARM32.h - Issue 1458523002: Add LDR/LDRB (register) to ARM integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstARM32.h

Issue 1458523002: Add LDR/LDRB (register) to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstARM32.h

diff --git a/src/IceInstARM32.h b/src/IceInstARM32.h

index 1b997790a50c200ea38aac492faad2edbf5e2502..f0240a13514e2a8773f3f2f5bf1d3cd89e90d3c7 100644

--- a/src/IceInstARM32.h

+++ b/src/IceInstARM32.h

@@ -76,7 +76,7 @@ public:

/// The enum value also carries the encoding.

// TODO(jvoung): unify with the assembler.

enum AddrMode {

- // bit encoding P U W

+ // bit encoding P U 0 W

Offset = (8 | 4 | 0) << 21, // offset (w/o writeback to base)

PreIndex = (8 | 4 | 1) << 21, // pre-indexed addressing with writeback

PostIndex = (0 | 4 | 0) << 21, // post-indexed addressing with writeback

« no previous file with comments | « src/IceAssemblerARM32.cpp ('k') | tests_lit/assembler/arm32/ldr-shift.ll » ('j') | no next file with comments »