Issue 1458373002: Merge to XFA: Add more overrides.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1458373002: Merge to XFA: Add more overrides. (Closed)

Created:
5 years, 1 month ago by Lei Zhang

Modified:
5 years, 1 month ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

More Reviews

Description

Merge to XFA: Add more overrides. Using Chromium's clang + build options, there's more override warnings. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1453643002 . (cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673) Committed: https://pdfium.googlesource.com/pdfium/+/5fd907b8266766152377a9836abfcac0161832fc

Patch Set 1 #

Total comments: 2

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -197 lines)			Patch
M	core/include/fpdfapi/fpdf_resource.h	View	2 chunks	+20 lines, -18 lines	0 comments	Download
M	core/include/fxcrt/fx_stream.h	View	3 chunks	+37 lines, -46 lines	1 comment	Download
M	core/src/fpdfapi/fpdf_font/ttgsubtable.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	core/src/fxcodec/codec/codec_int.h	View	3 chunks	+64 lines, -59 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jbig.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	core/src/fxcrt/extension.h	View	6 chunks	+20 lines, -20 lines	0 comments	Download
M	fpdfsdk/include/fsdk_baseannot.h	View	1 chunk	+11 lines, -15 lines	1 comment	Download
M	fpdfsdk/include/fxedit/fxet_edit.h	View	1 chunk	+12 lines, -7 lines	0 comments	Download
M	fpdfsdk/include/fxedit/fxet_list.h	View	1 chunk	+19 lines, -26 lines	0 comments	Download
M	fpdfsdk/include/pdfwindow/PWL_ComboBox.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lei Zhang

TBR https://codereview.chromium.org/1458373002/diff/1/core/include/fxcrt/fx_stream.h File core/include/fxcrt/fx_stream.h (right): https://codereview.chromium.org/1458373002/diff/1/core/include/fxcrt/fx_stream.h#newcode130 core/include/fxcrt/fx_stream.h:130: class IFX_FileAccess { Conflict: XFA only. https://codereview.chromium.org/1458373002/diff/1/fpdfsdk/include/fsdk_baseannot.h File ...

5 years, 1 month ago (2015-11-20 06:20:52 UTC) #1

Lei Zhang

5 years, 1 month ago (2015-11-20 06:21:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5fd907b8266766152377a9836abfcac0161832fc (presubmit successful).

Expand Messages | Collapse Messages