Add more overrides.

Add more overrides.

Using Chromium's clang + build options, there's more override warnings.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/126ba519bdd489ec6c285d1410dcae773e8ef673

[Lei Zhang, 2015-11-18 00:00:08]

Description was changed from

==========
Add more overrides.
==========

to

==========
Add more overrides.

Using Chromium's clang + build options, there's more override warnings.
==========

[Lei Zhang, 2015-11-18 00:00:09]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Lei Zhang, 2015-11-18 00:00:37]

This just adds overrides and groups methods together.

[Tom Sepez, 2015-11-18 00:36:22]

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_stream.h
File core/include/fxcrt/fx_stream.h (left):

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_strea...
core/include/fxcrt/fx_stream.h:68: virtual void Release() = 0;
what happened to Release()?

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_stream.h
File core/include/fxcrt/fx_stream.h (right):

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_strea...
core/include/fxcrt/fx_stream.h:94: void Release() override = 0;
I'd not seen override = 0 before.  Does that make sense?  Does it just take away
the parent class method if already present?

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_strea...
core/include/fxcrt/fx_stream.h:111: void Release() override = 0;
ditto

[Lei Zhang, 2015-11-19 00:39:04]

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_stream.h
File core/include/fxcrt/fx_stream.h (left):

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_strea...
core/include/fxcrt/fx_stream.h:68: virtual void Release() = 0;
On 2015/11/18 00:36:22, Tom Sepez wrote:
> what happened to Release()?

Doesn't it seem silly to override a pure virtual method with a pure virtual
method? I tried to remove as many as I can.

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_stream.h
File core/include/fxcrt/fx_stream.h (right):

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_strea...
core/include/fxcrt/fx_stream.h:94: void Release() override = 0;
On 2015/11/18 00:36:22, Tom Sepez wrote:
> I'd not seen override = 0 before.  Does that make sense?  Does it just take
away
> the parent class method if already present?

I tried removing this, but then the compiler realized IFX_FileStream has two
possible GetSize() and Release() methods to override and complained bitterly
about it. Yay diamonds!

So consider this a crutch? I can also omit this file from the CL, and try to do
something better in a separate CL.

https://codereview.chromium.org/1453643002/diff/1/core/include/fxcrt/fx_strea...
core/include/fxcrt/fx_stream.h:111: void Release() override = 0;
On 2015/11/18 00:36:22, Tom Sepez wrote:
> ditto

ditto ditto

[Tom Sepez, 2015-11-19 16:51:53]

LGTM. Let's land this as-is; those classes need some cleanup anyhow.

[Lei Zhang, 2015-11-20 06:09:36]

Committed patchset #2 (id:20001) manually as
126ba519bdd489ec6c285d1410dcae773e8ef673 (presubmit successful).