Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1850)

Issue 1458353004: Revert of Clip scrollbars to box bounds when they don't fit. (Closed)

Created:
5 years, 1 month ago by dcheng
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Clip scrollbars to box bounds when they don't fit. (patchset #6 id:180001 of https://codereview.chromium.org/1448253002/ ) Reason for revert: Causes PaintPropertyTreeBuilderTest.PositionAndScroll and DisplayItemTest.DebugStringsExist to fail on the debug bots. Original issue's description: > Clip scrollbars to box bounds when they don't fit. > > There are three cases: > > (1) scroller is a non-composited self-painting layer > (2) scroller is not a self-painting layer > (3) scroller is a composited layer > (3a) scroller is a composited layer that does not use composited scrolling > > Case (1) already worked correctly through the background clip applied by > PaintLayerPainter. Case (2) is addressed by the change in BlockPainter. > > Case (3) is addressed by the changes in CompositedLayerMapping. The clip is > applied by m_overflowControlsHostLayer. GraphicsLayerTreeBuilder is modified > to preserve the layer tree in case (3a). > > I have renamed m_overflowControlsClippingLayer for clarity, since the overflow > controls can now be clipped for two different reasons. > > Note that for an iframe with CSS "resize", the scroll corner comes from the > iframe element's CompositedLayerMapping, not the inner PaintLayerCompositor. > For this reason, PLC::attachFrameContentLayersToIframeLayer must preserve > overflow controls just like the "!parented" path of GraphicsLayerTreeBuilder. > > BUG=549174 > > Committed: https://crrev.com/bf0a5ac073c0844a514a979beab5c8b08a445393 > Cr-Commit-Position: refs/heads/master@{#360860} TBR=chrishtr@chromium.org,vollick@chromium.org,skobes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=549174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -361 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -68 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/iframes/resizer-expected.txt View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/layer-creation/fixed-position-in-fixed-overflow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/accelerated-overflow-scroll-should-not-affect-perspective-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/clear-scroll-parent-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/composited-scrolling-paint-phases-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/content-gains-scrollbars-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/overflow-scrollbar-layers-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/reparented-scrollbars-non-sc-anc-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/resize-painting-expected.txt View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/scroll-parent-absolute-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/scrolling-without-painting-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/universal-accelerated-overflow-scroll-expected.txt View 12 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/scrollbars/nested-overlay-scrollbars-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/composited-bounds-for-negative-z-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/update-paint-phases-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-move-after-scroll-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/overflow-scroll-after-move-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/invalidate-after-composited-scroll-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/layer-creation/fixed-position-nonscrollable-body-mismatch-containers-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 7 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/selection-gaps-toggling-expected.txt View 5 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 7 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/textarea-scroll-touch-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/compositing/repaint/should-not-clip-composited-overflow-scrolling-layer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/replaced/width100percent-textarea-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/selection/selection-within-composited-scroller-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-after-removing-scrolling-contents-expected.txt View 7 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-expected.txt View 5 chunks +4 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/selection-gaps-toggling-with-scrolling-contents-expected.txt View 7 chunks +6 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/text-color-change-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/text-match-highlight-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/textarea-scroll-touch-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-and-content-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/scrollbars/border-box-rect-clips-scrollbars.html View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/scrollbars/border-box-rect-clips-scrollbars-expected.png View Binary file 0 comments Download
D third_party/WebKit/LayoutTests/scrollbars/border-box-rect-clips-scrollbars-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/accelerated-overflow-scroll-should-not-affect-perspective-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/clear-scroll-parent-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/composited-scrolling-paint-phases-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/content-gains-scrollbars-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-auto-with-touch-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-overlay-with-touch-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/overflow-scrollbar-layers-expected.txt View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/reparented-scrollbars-non-sc-anc-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/resize-painting-expected.txt View 1 chunk +3 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-absolute-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/scrolling-without-painting-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/universal-accelerated-overflow-scroll-expected.txt View 12 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-container-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/prefer_compositing_to_lcd_text/compositing/overflow/updating-scrolling-content-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.h View 3 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp View 12 chunks +25 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/GraphicsLayerTreeBuilder.cpp View 1 chunk +22 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
dcheng
Created Revert of Clip scrollbars to box bounds when they don't fit.
5 years, 1 month ago (2015-11-20 21:15:57 UTC) #1
commit-bot: I haz the power
5 years, 1 month ago (2015-11-20 21:16:16 UTC) #2

Powered by Google App Engine
This is Rietveld 408576698