Port ChromeSyncShell build rules to GN

Port ChromeSyncShell build rules to GN

BUG=475612
R=agrieve, newt, pvalenzuela, zea
TBR=brettw for .gn whitelisting usage fo gypi_to_gn in protocol_sources.gni

Committed: https://crrev.com/9ae3420e37bfb6c2878b0d036db01af0d16af067
Cr-Commit-Position: refs/heads/master@{#361561}

[pkotwicz, 2015-11-20 04:42:57]

pkotwicz@chromium.org changed reviewers:
+ agrieve@chromium.org

[pkotwicz, 2015-11-20 04:42:58]

Andrew, can you please take a look?

[agrieve, 2015-11-20 15:09:25]

Practically perfect in every what :) lgtm

https://codereview.chromium.org/1458353002/diff/1/chrome/android/BUILD.gn
File chrome/android/BUILD.gn (right):

https://codereview.chromium.org/1458353002/diff/1/chrome/android/BUILD.gn#new...
chrome/android/BUILD.gn:417: gypi_values = exec_script("//build/gypi_to_gn.py",
Can you move this to be top-level so that the exec_script can be shared between
targets?

https://codereview.chromium.org/1458353002/diff/1/chrome/android/BUILD.gn#new...
chrome/android/BUILD.gn:445: version_name = "Developer Build"
nit: this is already the default value for version_name and version_code, can
just delete.

https://codereview.chromium.org/1458353002/diff/1/chrome/android/BUILD.gn#new...
chrome/android/BUILD.gn:485: ":chrome_java",
nit: move some of these deps to chrome_public_apk_tmpl_shared?

[pkotwicz, 2015-11-20 16:58:08]

pkotwicz@chromium.org changed reviewers:
+ newt@chromium.org

[pkotwicz, 2015-11-20 16:58:09]

newt@ for OWNERS

[pkotwicz, 2015-11-20 16:59:52]

pkotwicz@chromium.org changed reviewers:
+ zea@chromium.org

[pkotwicz, 2015-11-20 16:59:52]

newt@ for chrome/android OWNERS
zea@ for sync/ OWNERS

[newt (away), 2015-11-20 23:44:25]

lgtm, thanks!

[pval...(no longer on Chromium), 2015-11-23 19:16:46]

pvalenzuela@chromium.org changed reviewers:
+ pvalenzuela@chromium.org

[pval...(no longer on Chromium), 2015-11-23 19:16:46]

Thanks so much for doing this work! This would have taken me a lot longer to do.

 I'll give my (probably useless) lgtm here, but zea can provide the one for
sync-wide approval.

lgtm

[Nicolas Zea, 2015-11-23 23:13:37]

rs sync owners lgtm

[pkotwicz, 2015-11-24 19:44:40]

Description was changed from

==========
Port ChromeSyncShell build rules to GN

BUG=475612
==========

to

==========
Port ChromeSyncShell build rules to GN

BUG=475612
R=agrieve, zea, pvalenzuela
TBR=brettw for .gn whiteliesting usage fo gypi_to_gn in protocol_sources.gni
==========

[pkotwicz, 2015-11-24 19:44:45]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-11-24 19:44:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
agrieve@chromium.org, newt@chromium.org, zea@chromium.org,
pvalenzuela@chromium.org
Link to the patchset: https://codereview.chromium.org/1458353002/#ps40001
(title: " ")

[pkotwicz, 2015-11-24 19:44:52]

The CQ bit was unchecked by pkotwicz@chromium.org

[pkotwicz, 2015-11-24 19:45:09]

Description was changed from

==========
Port ChromeSyncShell build rules to GN

BUG=475612
R=agrieve, zea, pvalenzuela
TBR=brettw for .gn whiteliesting usage fo gypi_to_gn in protocol_sources.gni
==========

to

==========
Port ChromeSyncShell build rules to GN

BUG=475612
R=agrieve, newt, pvalenzuela, zea
TBR=brettw for .gn whiteliesting usage fo gypi_to_gn in protocol_sources.gni
==========

[pkotwicz, 2015-11-24 19:45:24]

Description was changed from

==========
Port ChromeSyncShell build rules to GN

BUG=475612
R=agrieve, newt, pvalenzuela, zea
TBR=brettw for .gn whiteliesting usage fo gypi_to_gn in protocol_sources.gni
==========

to

==========
Port ChromeSyncShell build rules to GN

BUG=475612
R=agrieve, newt, pvalenzuela, zea
TBR=brettw for .gn whitelisting usage fo gypi_to_gn in protocol_sources.gni
==========

[pkotwicz, 2015-11-24 19:45:30]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-11-24 19:46:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458353002/40001

[commit-bot: I haz the power, 2015-11-24 21:02:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 21:02:31]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pkotwicz, 2015-11-25 02:58:28]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-11-25 02:58:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1458353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1458353002/40001

[commit-bot: I haz the power, 2015-11-25 03:52:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-11-25 03:53:14]

Patchset 3 (id:??) landed as
https://crrev.com/9ae3420e37bfb6c2878b0d036db01af0d16af067
Cr-Commit-Position: refs/heads/master@{#361561}