Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1458163002: Remove |using base::StringPiece| from net/spdy header files. (Closed)

Created:
5 years, 1 month ago by Bence
Modified:
5 years ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |using base::StringPiece| from net/spdy header files. |using| directives should not be global, but they should be used on a per-file bases. Therefore they should not be placed in header files. Committed: https://crrev.com/27114889b608254dab9266fbcae805714c707c13 Cr-Commit-Position: refs/heads/master@{#361378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -38 lines) Patch
M net/spdy/hpack/hpack_header_table.h View 4 chunks +9 lines, -8 lines 0 comments Download
M net/spdy/hpack/hpack_static_table.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.h View 2 chunks +13 lines, -15 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/spdy/spdy_alt_svc_wire_format_test.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_framer_test.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M net/spdy/spdy_header_block_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/spdy_session.h View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_test_utils.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/flip_server/spdy_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Bence
ttuttle@: PTAL. Thanks.
5 years, 1 month ago (2015-11-19 20:29:47 UTC) #3
Deprecated (see juliatuttle)
lgtm.
5 years ago (2015-11-24 15:30:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458163002/1
5 years ago (2015-11-24 15:34:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 17:16:12 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-24 17:17:17 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27114889b608254dab9266fbcae805714c707c13
Cr-Commit-Position: refs/heads/master@{#361378}

Powered by Google App Engine
This is Rietveld 408576698