Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: net/spdy/hpack/hpack_header_table.h

Issue 1458163002: Remove |using base::StringPiece| from net/spdy header files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/hpack/hpack_static_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/hpack/hpack_header_table.h
diff --git a/net/spdy/hpack/hpack_header_table.h b/net/spdy/hpack/hpack_header_table.h
index e60a758ce7992f62198afddef5e516cda6f744f6..881bb7cf4f81c3572254948bf6c32bea9132c3ea 100644
--- a/net/spdy/hpack/hpack_header_table.h
+++ b/net/spdy/hpack/hpack_header_table.h
@@ -18,8 +18,6 @@
namespace net {
-using base::StringPiece;
-
namespace test {
class HpackHeaderTablePeer;
} // namespace test
@@ -62,10 +60,11 @@ class NET_EXPORT_PRIVATE HpackHeaderTable {
const HpackEntry* GetByIndex(size_t index);
// Returns the lowest-value entry having |name|, or NULL.
- const HpackEntry* GetByName(StringPiece name);
+ const HpackEntry* GetByName(base::StringPiece name);
// Returns the lowest-index matching entry, or NULL.
- const HpackEntry* GetByNameAndValue(StringPiece name, StringPiece value);
+ const HpackEntry* GetByNameAndValue(base::StringPiece name,
+ base::StringPiece value);
// Returns the index of an entry within this header table.
size_t IndexOf(const HpackEntry* entry) const;
@@ -81,8 +80,8 @@ class NET_EXPORT_PRIVATE HpackHeaderTable {
// Determine the set of entries which would be evicted by the insertion
// of |name| & |value| into the table, as per section 4.4. No eviction
// actually occurs. The set is returned via range [begin_out, end_out).
- void EvictionSet(StringPiece name,
- StringPiece value,
+ void EvictionSet(base::StringPiece name,
+ base::StringPiece value,
EntryTable::iterator* begin_out,
EntryTable::iterator* end_out);
@@ -90,13 +89,15 @@ class NET_EXPORT_PRIVATE HpackHeaderTable {
// and |value| must not be owned by an entry which could be evicted. The
// added HpackEntry is returned, or NULL is returned if all entries were
// evicted and the empty table is of insufficent size for the representation.
- const HpackEntry* TryAddEntry(StringPiece name, StringPiece value);
+ const HpackEntry* TryAddEntry(base::StringPiece name,
+ base::StringPiece value);
void DebugLogTableState() const;
private:
// Returns number of evictions required to enter |name| & |value|.
- size_t EvictionCountForEntry(StringPiece name, StringPiece value) const;
+ size_t EvictionCountForEntry(base::StringPiece name,
+ base::StringPiece value) const;
// Returns number of evictions required to reclaim |reclaim_size| table size.
size_t EvictionCountToReclaim(size_t reclaim_size) const;
« no previous file with comments | « no previous file | net/spdy/hpack/hpack_static_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698