Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1458103003: Make arguments adaptor not clobber new.target. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-pass-new-target-1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make arguments adaptor not clobber new.target. This ensures that the ArgumentsAdaptorTrampoline does not clobber the new.target value, but rather passes it through to the callee unaltered. Note that callees do not yet use the new.target value so far. This is a preparatory CL to allows us passing new.target in a register instead of via a side-channel through the construct stub frame. R=mvstanton@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/c1e7c8d972e8a42878dcae6bf1ad33997608e7b3 Cr-Commit-Position: refs/heads/master@{#32171}

Patch Set 1 #

Patch Set 2 : Minor fix. #

Patch Set 3 : Ported to some architectures. #

Patch Set 4 : Ported to more architectures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -75 lines) Patch
M src/arm/builtins-arm.cc View 1 2 8 chunks +15 lines, -12 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 6 chunks +9 lines, -7 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 6 chunks +16 lines, -15 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 9 chunks +15 lines, -12 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 2 3 9 chunks +15 lines, -12 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 2 6 chunks +19 lines, -17 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
Michael Starzinger
5 years, 1 month ago (2015-11-20 13:12:28 UTC) #4
Michael Starzinger
Ports done. This is ready for final review. Thanks!
5 years, 1 month ago (2015-11-20 15:55:51 UTC) #5
mvstanton
LGTM, nice touch to move the stack check...
5 years, 1 month ago (2015-11-20 19:55:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1458103003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1458103003/60001
5 years, 1 month ago (2015-11-23 09:24:02 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-23 09:54:57 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 09:55:41 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c1e7c8d972e8a42878dcae6bf1ad33997608e7b3
Cr-Commit-Position: refs/heads/master@{#32171}

Powered by Google App Engine
This is Rietveld 408576698