[turbofan] Switch passing of new.target to register.

[turbofan] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. Note that only TurboFan code uses
the register value so far, but unoptimized code will be switched soon.

R=bmeurer@chromium.org
BUG=v8:4544
LOG=n

Committed: https://crrev.com/7c45b005296fc326490a0703add50505518aaa51
Cr-Commit-Position: refs/heads/master@{#32203}

[Michael Starzinger, 2015-11-20 16:24:26]

Description was changed from

==========
[turbofan] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. Note that only TurboFan code uses
the register value so far, but unoptimized code will be switched soon.

R=bmeurer@chromium.org,yangguo@chromium.org
BUG=v8:4544
LOG=n
==========

to

==========
[turbofan] Switch passing of new.target to register.

This passes the new.target value in a register instead of through a
side-channel via the construct stub. Note that only TurboFan code uses
the register value so far, but unoptimized code will be switched soon.

R=bmeurer@chromium.org
BUG=v8:4544
LOG=n
==========

[Michael Starzinger, 2015-11-20 16:25:09]

Benedikt: PTAL, ports missing, but ready for first round.
Yang: FYI, because you are working on related code.

[Michael Starzinger, 2015-11-20 16:46:13]

mstarzinger@chromium.org changed reviewers:
+ oth@chromium.org

[Michael Starzinger, 2015-11-20 16:46:14]

Orion: FYI, because I plan to switch the interpreter and fully remove
Runtime_GetNewTarget sometime next week.

[Benedikt Meurer, 2015-11-23 05:24:22]

LGTM with question. Thanks for doing this Michi.

https://codereview.chromium.org/1460503008/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/1460503008/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.h:159: Node* GetIncomingNewTarget();
I don't have a strong opinion on this, but why didn't you name it GetNewTarget?
The "Incoming" seems redundant and slightly confusing.

[Michael Starzinger, 2015-11-23 11:40:27]

Thanks. Will do ports now.

https://codereview.chromium.org/1460503008/diff/1/src/compiler/ast-graph-buil...
File src/compiler/ast-graph-builder.h (right):

https://codereview.chromium.org/1460503008/diff/1/src/compiler/ast-graph-buil...
src/compiler/ast-graph-builder.h:159: Node* GetIncomingNewTarget();
On 2015/11/23 05:24:21, Benedikt Meurer wrote:
> I don't have a strong opinion on this, but why didn't you name it
GetNewTarget?
> The "Incoming" seems redundant and slightly confusing.

Done. You are right. Dropped the "Incoming", just "NewTarget", it's cleaner. :)

[Michael Starzinger, 2015-11-24 09:29:49]

Ports done.

[Michael Starzinger, 2015-11-24 11:37:28]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2015-11-24 11:37:28]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1460503008/#ps100001
(title: "Ported to MIPS64.")

[commit-bot: I haz the power, 2015-11-24 11:37:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1460503008/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1460503008/100001

[commit-bot: I haz the power, 2015-11-24 11:39:19]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-11-24 11:39:28]

Patchset 6 (id:??) landed as
https://crrev.com/7c45b005296fc326490a0703add50505518aaa51
Cr-Commit-Position: refs/heads/master@{#32203}