Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457803002: Register data_reduction_proxy prefs on iOS. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years, 1 month ago
Reviewers:
blundell
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@io-thread-testing-fixed-http-port
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register data_reduction_proxy prefs on iOS. BUG=556566 Committed: https://crrev.com/e471c20b51e0d1b1eb5feab50452b62c94457f61 Cr-Commit-Position: refs/heads/master@{#361017}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M ios/chrome/browser/prefs/browser_prefs.mm View 2 chunks +9 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1456023002 Patch 1

Dependent Patchsets:

Issue 1463973003 Patch 1

Messages

Total messages: 8 (2 generated)
sdefresne
Please take a look. Please do *not* send to CQ as this requires landing some ...
5 years, 1 month ago (2015-11-18 17:42:49 UTC) #2
blundell
Holding off pending discussion of the question I asked on this CL's counterpart.
5 years, 1 month ago (2015-11-19 12:35:14 UTC) #3
blundell
lgtm
5 years, 1 month ago (2015-11-19 13:29:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457803002/1
5 years, 1 month ago (2015-11-21 08:28:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-21 09:11:32 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-21 09:12:20 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e471c20b51e0d1b1eb5feab50452b62c94457f61
Cr-Commit-Position: refs/heads/master@{#361017}

Powered by Google App Engine
This is Rietveld 408576698