Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1463973003: Move kDataReductionProxy registration to the data_reduction_proxy component. (Closed)

Created:
5 years, 1 month ago by sdefresne
Modified:
5 years ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@xxx
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move kDataReductionProxy registration to the data_reduction_proxy component. The pref data_reduction_proxy::prefs::kDataReductionProxy should have been part of data_reduction_proxy::RegisterPrefs() to avoid having all embedder register it manually just before call said function. BUG=557814 Committed: https://crrev.com/00e1e6c710ed420e00cf457b5048d813b7a3c2cb Cr-Commit-Position: refs/heads/master@{#361358}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M chrome/browser/io_thread.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/prefs/browser_prefs.mm View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
sdefresne
kundaji: could you review the following as OWNERS - components/data_reduction_proxy mmenke: could you review the ...
5 years, 1 month ago (2015-11-21 08:55:59 UTC) #2
droger
lgtm
5 years ago (2015-11-23 08:55:33 UTC) #3
Not at Google. Contact bengr
lgtm
5 years ago (2015-11-23 18:15:56 UTC) #4
mmenke
On 2015/11/23 18:15:56, kundaji wrote: > lgtm LGTM, thanks for the cleanup!
5 years ago (2015-11-23 18:19:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463973003/1
5 years ago (2015-11-24 08:52:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/98580)
5 years ago (2015-11-24 08:58:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1463973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1463973003/20001
5 years ago (2015-11-24 15:13:48 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-24 16:26:46 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-24 16:28:22 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/00e1e6c710ed420e00cf457b5048d813b7a3c2cb
Cr-Commit-Position: refs/heads/master@{#361358}

Powered by Google App Engine
This is Rietveld 408576698