Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1457753002: Clean up dead code: PictureRenderer (Closed)

Created:
5 years, 1 month ago by mtklein_C
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up dead code: PictureRenderer Doesn't appear to actually be used by anything. BUG=skia: Committed: https://skia.googlesource.com/skia/+/835c1b69a2b4238b63ad2daf0698c4fbb5fc944f

Patch Set 1 #

Patch Set 2 : missed #

Patch Set 3 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1519 lines) Patch
M debugger/QT/SkDebuggerGUI.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M gyp/tools.gyp View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D tools/PictureRenderer.h View 1 chunk +0 lines, -737 lines 0 comments Download
D tools/PictureRenderer.cpp View 1 chunk +0 lines, -739 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457753002/1
5 years, 1 month ago (2015-11-18 13:55:31 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457753002/20001
5 years, 1 month ago (2015-11-18 13:56:21 UTC) #4
mtklein_C
5 years, 1 month ago (2015-11-18 14:02:22 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-18 14:11:25 UTC) #9
mtklein
+Brian
5 years, 1 month ago (2015-11-18 15:45:22 UTC) #11
bsalomon
lgtm
5 years, 1 month ago (2015-11-18 16:22:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457753002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457753002/20001
5 years, 1 month ago (2015-11-18 16:23:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/3997)
5 years, 1 month ago (2015-11-18 16:24:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457753002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457753002/40001
5 years, 1 month ago (2015-11-18 17:28:48 UTC) #19
commit-bot: I haz the power
5 years, 1 month ago (2015-11-18 17:41:10 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/835c1b69a2b4238b63ad2daf0698c4fbb5fc944f

Powered by Google App Engine
This is Rietveld 408576698