Issue 145773004: IDL compiler: [ReflectOnly]

Issue 145773004: IDL compiler: [ReflectOnly] (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)

Modified:
6 years, 10 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: [ReflectOnly] Python side to: Support IDL attributes limited to only known values. https://codereview.chromium.org/124763002/ BUG=239771 R=haraken NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166456

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+157 lines, -0 lines)			Patch
M	Source/bindings/scripts/unstable/v8_attributes.py	View	2 chunks	+7 lines, -0 lines	1 comment	Download
M	Source/bindings/templates/attributes.cpp	View	2 chunks	+20 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/idls/TestObjectPython.idl	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestObjectPython.cpp	View	2 chunks	+120 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nils Barth (inactive)

https://codereview.chromium.org/145773004/diff/1/Source/bindings/scripts/unstable/v8_attributes.py File Source/bindings/scripts/unstable/v8_attributes.py (right): https://codereview.chromium.org/145773004/diff/1/Source/bindings/scripts/unstable/v8_attributes.py#newcode175 Source/bindings/scripts/unstable/v8_attributes.py:175: cpp_value = 'resultValue' The local variable is called 'resultValue', ...

6 years, 10 months ago (2014-02-05 06:11:42 UTC) #1

Nils Barth (inactive)

The CQ bit was checked by nbarth@chromium.org

6 years, 10 months ago (2014-02-05 06:16:11 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/145773004/1

6 years, 10 months ago (2014-02-05 06:17:01 UTC) #4

Message was sent while issue was closed.

Change committed as 166456

Expand Messages | Collapse Messages