Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457623003: Clamp animated numbers according to ComputedStyle data type (Closed)

Created:
5 years, 1 month ago by alancutter (OOO until 2018)
Modified:
5 years, 1 month ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clamp animated numbers according to ComputedStyle data type This change ensures we clamp animated numbers to the range representable by ComputedStyle objects instead of overflowing. BUG=557102 Committed: https://crrev.com/2b1365319b986ba0a74e576cd012af8863cd0c18 Cr-Commit-Position: refs/heads/master@{#360487}

Patch Set 1 #

Patch Set 2 : Update test #

Total comments: 2

Patch Set 3 : Review changes #

Patch Set 4 : var #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/animations/big-number-clamping.html View 1 2 3 1 chunk +35 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp View 1 2 1 chunk +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
alancutter (OOO until 2018)
5 years, 1 month ago (2015-11-18 00:05:11 UTC) #2
Eric Willigers
https://codereview.chromium.org/1457623003/diff/20001/third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp File third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp (left): https://codereview.chromium.org/1457623003/diff/20001/third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp#oldcode115 third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp:115: case CSSPropertyWebkitColumnRuleWidth: AnimatedStyleBuilder::applyProperty and ComputedStyle::setColumnRuleWidth mention unsigned short.
5 years, 1 month ago (2015-11-18 00:18:54 UTC) #5
alancutter (OOO until 2018)
https://codereview.chromium.org/1457623003/diff/20001/third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp File third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp (left): https://codereview.chromium.org/1457623003/diff/20001/third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp#oldcode115 third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp:115: case CSSPropertyWebkitColumnRuleWidth: On 2015/11/18 at 00:18:54, Eric Willigers wrote: ...
5 years, 1 month ago (2015-11-18 00:33:28 UTC) #6
dstockwell
lgtm https://codereview.chromium.org/1457623003/diff/60001/third_party/WebKit/LayoutTests/animations/big-number-clamping.html File third_party/WebKit/LayoutTests/animations/big-number-clamping.html (right): https://codereview.chromium.org/1457623003/diff/60001/third_party/WebKit/LayoutTests/animations/big-number-clamping.html#newcode15 third_party/WebKit/LayoutTests/animations/big-number-clamping.html:15: var numberProperties = [ I wonder if there's ...
5 years, 1 month ago (2015-11-18 23:52:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457623003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457623003/60001
5 years, 1 month ago (2015-11-19 00:01:32 UTC) #9
alancutter (OOO until 2018)
https://codereview.chromium.org/1457623003/diff/60001/third_party/WebKit/LayoutTests/animations/big-number-clamping.html File third_party/WebKit/LayoutTests/animations/big-number-clamping.html (right): https://codereview.chromium.org/1457623003/diff/60001/third_party/WebKit/LayoutTests/animations/big-number-clamping.html#newcode15 third_party/WebKit/LayoutTests/animations/big-number-clamping.html:15: var numberProperties = [ On 2015/11/18 at 23:52:00, dstockwell ...
5 years, 1 month ago (2015-11-19 00:10:07 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-19 02:18:14 UTC) #11
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 02:19:01 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2b1365319b986ba0a74e576cd012af8863cd0c18
Cr-Commit-Position: refs/heads/master@{#360487}

Powered by Google App Engine
This is Rietveld 408576698