third_party/WebKit/LayoutTests/animations/big-number-clamping.html - Issue 1457623003: Clamp animated numbers according to ComputedStyle data type

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/animations/big-number-clamping.html

Issue 1457623003: Clamp animated numbers according to ComputedStyle data type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: var Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <style>

	5 div {

	6 /* This is required so that z-index doesn't compute as auto. */

	7 position: relative;

	8 }

	9 </style>

	10

	11 <div id="animated"></div>

	12 <div id="reference"></div>

	13

	14 <script>

	15 var numberProperties = [
	dstockwell 2015/11/18 23:52:00 I wonder if there's a way to test all properties. I wonder if there's a way to test all properties. First discover the properties that accept number and can be interpolated. CSS.supports? alancutter (OOO until 2018) 2015/11/19 00:10:07 CSSOM2 would be good for this case. Show quoted text On 2015/11/18 at 23:52:00, dstockwell wrote: > I wonder if there's a way to test all properties. First discover the properties that accept number and can be interpolated. CSS.supports? CSSOM2 would be good for this case.
	16 'flex-grow',

	17 'flex-shrink',

	18 'font-size-adjust',

	19 'line-height',

	20 'orphans',

	21 'stroke-miterlimit',

	22 'widows',

	23 'z-index',

	24 ];

	25

	26 var bigNumber = 1e20;

	27

	28 for (var property of numberProperties) {

	29 test(() => {

	30 animated.animate({[property]: bigNumber}, {fill: 'forwards'});

	31 reference.style[property] = bigNumber;

	32 assert_equals(getComputedStyle(animated)[property], getComputedStyle(referen ce)[property]);

	33 }, `Animations on ${property} should clamp identically to setting inline style `);

	34 }

	35 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/animation/NumberPropertyFunctions.cpp » ('j') | no next file with comments »