Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1457593005: Revert of Flip 'Linux x64' bot on chromium waterfall to GN. (Closed)

Created:
5 years, 1 month ago by Dirk Pranke
Modified:
5 years, 1 month ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Flip 'Linux x64' bot on chromium waterfall to GN. (patchset #2 id:20001 of https://codereview.chromium.org/1461453002/ ) Reason for revert: compiling 'all' fails w/ GN: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/12149/steps/compile/logs/stdio Original issue's description: > Flip 'Linux x64' bot on chromium waterfall to GN. > > This flips the Linux x64 bot on the chromium waterfall to > GN, and cleans up some mistakes in the MB config (the > builders should've been setting linux_dump_symbols=0, > which is the default, not linux_dump_symbols=1). > > TBR=phajdan.jr@chromium.org, brettw@chromium.org > BUG=530733, 432959 > > Committed: https://crrev.com/9bb757129af95f0ca1539c65269cd8bc85df04f8 > Cr-Commit-Position: refs/heads/master@{#360510} TBR=phajdan.jr@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=530733, 432959 Committed: https://crrev.com/8712d995456e8ec14f36cdfbf16086175d9011ac Cr-Commit-Position: refs/heads/master@{#360544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M BUILD.gn View 1 chunk +1 line, -6 lines 0 comments Download
M remoting/host/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M tools/mb/mb_config.pyl View 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Created Revert of Flip 'Linux x64' bot on chromium waterfall to GN.
5 years, 1 month ago (2015-11-19 08:48:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457593005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457593005/1
5 years, 1 month ago (2015-11-19 08:49:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 08:50:58 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 08:52:05 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8712d995456e8ec14f36cdfbf16086175d9011ac
Cr-Commit-Position: refs/heads/master@{#360544}

Powered by Google App Engine
This is Rietveld 408576698