Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: tools/mb/mb_config.pyl

Issue 1457593005: Revert of Flip 'Linux x64' bot on chromium waterfall to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/mb/mb_config.pyl
diff --git a/tools/mb/mb_config.pyl b/tools/mb/mb_config.pyl
index cb26773043e0137f08e936b1e774808e4bd4c5c7..97f68846b7a0515b1460e8cb22dadb429709fc84 100644
--- a/tools/mb/mb_config.pyl
+++ b/tools/mb/mb_config.pyl
@@ -60,10 +60,10 @@
# This is just for completeness; any bot that uses this config should never actually run MB.
'none': ['none'],
- 'noswarming_gn_release_bot': ['noswarming', 'gn', 'release_bot'],
'noswarming_gyp_release_bot': ['noswarming', 'gyp', 'release_bot'],
+ 'noswarming_gyp_release_bot_linux_dump_symbols': ['noswarming', 'gyp', 'release_bot', 'linux_dump_symbols'],
'noswarming_gyp_release_bot_mac_strip': ['noswarming', 'gyp', 'release_bot', 'mac_strip'],
- 'noswarming_gyp_release_bot_x86': ['noswarming', 'gyp', 'release_bot', 'x86'],
+ 'noswarming_gyp_release_bot_x86_linux_dump_symbols': ['noswarming', 'gyp', 'release_bot', 'x86', 'linux_dump_symbols'],
'swarming_asan_lsan_gyp_release_trybot': ['swarming', 'asan', 'lsan', 'release_trybot'],
'swarming_msan_gyp_release_trybot': ['swarming', 'chromeos', 'msan', 'gyp', 'release_trybot'],
@@ -243,6 +243,11 @@
'libfuzzer': { 'gn_args': 'use_libfuzzer=true' },
+ 'linux_dump_symbols': {
+ 'gn_args': '', # TODO(GYP): Port linux_dump_symbols?
+ 'gyp_defines': 'linux_dump_symbols=1',
+ },
+
'lsan': {
'gn_args': 'use_lsan=true',
'gyp_defines': 'lsan=1',
@@ -278,7 +283,6 @@
},
'noswarming': {
- # test_isolation_mode doesn't exist in a GN build (it's always a no-op).
'gn_args': '',
'gyp_defines': 'test_isolation_mode=noop',
},
@@ -352,8 +356,8 @@
'chromium': {
'Win': 'noswarming_gyp_release_bot',
'Mac': 'noswarming_gyp_release_bot_mac_strip',
- 'Linux x64': 'noswarming_gn_release_bot',
- 'Linux': 'noswarming_gyp_release_bot_x86',
+ 'Linux x64': 'noswarming_gyp_release_bot_linux_dump_symbols',
+ 'Linux': 'noswarming_gyp_release_bot_x86_linux_dump_symbols',
'Android': 'android_gyp_release_bot_minimal_symbols',
},
'chromium.android': {
@@ -496,7 +500,7 @@
'linux_arm_tester': 'none',
'linux_chromium_compile_dbg_32_ng': 'swarming_gyp_debug_trybot_x86',
'linux_chromium_dbg_32_ng': 'swarming_gyp_debug_trybot_x86',
- 'linux_chromium_archive_rel_ng': 'noswarming_gn_release_bot',
+ 'linux_chromium_archive_rel_ng': 'noswarming_gyp_release_bot_linux_dump_symbols',
'linux_chromium_clobber_rel_ng': 'gyp_release_trybot',
'linux_chromium_gn_upload': 'gn_linux_upload',
'cast_shell_linux': 'cast_gyp_release_trybot',
« no previous file with comments | « remoting/host/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698