Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1457523002: MIPS: Enable logical shift right and bitwise And matching to Ext, Dext. (Closed)

Created:
5 years, 1 month ago by dusan.milosavljevic
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Enable logical shift right and bitwise And matching to Ext, Dext. TEST=unittests/InstructionSelectorTest/Word32ShrWithWord32AndWithImmediate, Word32AndWithImmediateWithWord32Shr, Word64AndWithImmediateWithWord64Shr, Word64AndWithImmediateWithWord64Shr BUG= Committed: https://crrev.com/74145470ddda3c721daf3a269a3761ef77f4d174 Cr-Commit-Position: refs/heads/master@{#32062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -0 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +52 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 3 chunks +104 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 2 chunks +79 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 2 chunks +161 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dusan.milosavljevic
PTAL.
5 years, 1 month ago (2015-11-17 19:25:06 UTC) #2
paul.l...
LGTM. Thanks.
5 years, 1 month ago (2015-11-17 21:11:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457523002/1
5 years, 1 month ago (2015-11-17 22:53:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-17 23:10:32 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-17 23:11:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74145470ddda3c721daf3a269a3761ef77f4d174
Cr-Commit-Position: refs/heads/master@{#32062}

Powered by Google App Engine
This is Rietveld 408576698