Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1457503002:
Parametric contour start GM (Closed)
DescriptionParametric contour start GM
A GM to capture the newly added SkPath API.
BUG=chromium:315277
R=caryclark@google.com,reed@google.com
Committed: https://skia.googlesource.com/skia/+/e55c312929fe5a4e65158d848a4b190e8fbf8c7c
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
Produces: http://imgur.com/7djH5d0
The CQ bit was checked by fmalita@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457503002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457503002/1
Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2015-11-18 02:33 UTC
lgtm
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/56847a65648af4d06da9c26c55242949a1bf31ab
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1456973002/ by stephana@google.com. The reason for reverting is: Breaks unit test across various platforms: ../../../src/gpu/batches/GrStencilAndCoverPathRenderer.cpp:75: failed assertion "path->isEqualTo(skPath, stroke)".
Message was sent while issue was closed.
Description was changed from ========== Parametric contour start GM A GM to capture the newly added SkPath API. BUG=chromium:315277 R=caryclark@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/56847a65648af4d06da9c26c55242949a1bf31ab ========== to ========== Parametric contour start GM A GM to capture the newly added SkPath API. BUG=chromium:315277 R=caryclark@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/56847a65648af4d06da9c26c55242949a1bf31ab ==========
On 2015/11/18 14:21:21, stephana wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/1456973002/ by mailto:stephana@google.com. > > The reason for reverting is: Breaks unit test across various platforms: > > ../../../src/gpu/batches/GrStencilAndCoverPathRenderer.cpp:75: failed assertion > "path->isEqualTo(skPath, stroke)". This should be safe to reland after https://codereview.chromium.org/1457073002
Description was changed from ========== Parametric contour start GM A GM to capture the newly added SkPath API. BUG=chromium:315277 R=caryclark@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/56847a65648af4d06da9c26c55242949a1bf31ab ========== to ========== Parametric contour start GM A GM to capture the newly added SkPath API. BUG=chromium:315277 R=caryclark@google.com,reed@google.com ==========
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457503002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e55c312929fe5a4e65158d848a4b190e8fbf8c7c |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
