[Reland] Fix NVPR assert for equivalent ovals

[Reland] Fix NVPR assert for equivalent ovals

For oval paths, GrPath ignores the point order and only uses the bounds
when building its key.  This is problematic because

1) point order is important when dashing
2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal
   to the cached SkPath - which is not the case for ovals with different
   directions/different point order.

With this CL we no longer use the reduced oval key when dashing, and
instead fall through to the more general path cases.  The assert is
adjusted to accommodate "equivalent" ovals (when not dashing).

Also re-enabled & updated the GpuDrawPath unit test (disabled in
https://codereview.chromium.org/1456463003/, presumably due to the use
of uninitialized SkRects).

R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com

Committed: https://skia.googlesource.com/skia/+/fbe1c110acf218a7b2b5d378a752dc1845816d6e

[f(malita), 2015-11-18 21:10:20]

Description was changed from

==========
Fix NVPR assert for equivalent ovals

For oval paths, GrPath ignores the point order and only uses the bounds
when building its key.  This is problematic because

1) point order is important when dashing
2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal
   to the cached SkPath - which is not the case for ovals with different
   directions/different point order.

With this CL we no longer use the reduced oval key when dashing, and
instead fall through to the more general path cases.  The assert is
adjusted to accommodate "equivalent" ovals (when not dashing).

Also re-enabled & updated the GpuDrawPath unit test (disabled in
https://codereview.chromium.org/1456463003/, presumably due to the use
of uninitialized SkRects).

R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com
==========

to

==========
Fix NVPR assert for equivalent ovals

For oval paths, GrPath ignores the point order and only uses the bounds
when building its key.  This is problematic because

1) point order is important when dashing
2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal
   to the cached SkPath - which is not the case for ovals with different
   directions/different point order.

With this CL we no longer use the reduced oval key when dashing, and
instead fall through to the more general path cases.  The assert is
adjusted to accommodate "equivalent" ovals (when not dashing).

Also re-enabled & updated the GpuDrawPath unit test (disabled in
https://codereview.chromium.org/1456463003/, presumably due to the use
of uninitialized SkRects).

R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com
==========

[bsalomon, 2015-11-18 21:15:05]

lgtm

[f(malita), 2015-11-18 21:17:32]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-11-18 21:17:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457073002/1

[commit-bot: I haz the power, 2015-11-18 21:36:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-18 21:36:24]

Dry run: This issue passed the CQ dry run.

[f(malita), 2015-11-18 22:06:21]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2015-11-18 22:06:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457073002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457073002/1

[commit-bot: I haz the power, 2015-11-18 22:07:15]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f9b1577d763988ebc043ddabf80674f71571ecff

[stephana, 2015-11-19 02:35:44]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1461913002/ by stephana@google.com.

The reason for reverting is: Causes failures on Android and Win8:

...
( 137/1245MB      9) 73.9ms	unit test 
GpuLayerCachec:\0\build\slave\workdir\build\skia\include\private\skuniqueptr.h:164:
failed assertion "get() != pointer()"

Caught exception 2147483651 EXCEPTION_BREAKPOINT
....

[f(malita), 2015-11-19 02:56:39]

Description was changed from

==========
Fix NVPR assert for equivalent ovals

For oval paths, GrPath ignores the point order and only uses the bounds
when building its key.  This is problematic because

1) point order is important when dashing
2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal
   to the cached SkPath - which is not the case for ovals with different
   directions/different point order.

With this CL we no longer use the reduced oval key when dashing, and
instead fall through to the more general path cases.  The assert is
adjusted to accommodate "equivalent" ovals (when not dashing).

Also re-enabled & updated the GpuDrawPath unit test (disabled in
https://codereview.chromium.org/1456463003/, presumably due to the use
of uninitialized SkRects).

R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com

Committed:
https://skia.googlesource.com/skia/+/f9b1577d763988ebc043ddabf80674f71571ecff
==========

to

==========
[Reland] Fix NVPR assert for equivalent ovals

For oval paths, GrPath ignores the point order and only uses the bounds
when building its key.  This is problematic because

1) point order is important when dashing
2) GrStencilAndCoverPathRenderer asserts that the lookup SkPath is equal
   to the cached SkPath - which is not the case for ovals with different
   directions/different point order.

With this CL we no longer use the reduced oval key when dashing, and
instead fall through to the more general path cases.  The assert is
adjusted to accommodate "equivalent" ovals (when not dashing).

Also re-enabled & updated the GpuDrawPath unit test (disabled in
https://codereview.chromium.org/1456463003/, presumably due to the use
of uninitialized SkRects).

R=bsalomon@google.com,robertphillips@google.com,cdalton@nvidia.com
==========

[f(malita), 2015-11-19 04:01:02]

On 2015/11/19 02:35:44, stephana wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1461913002/ by mailto:stephana@google.com.
> 
> The reason for reverting is: Causes failures on Android and Win8:
> 
> ...
> ( 137/1245MB      9) 73.9ms	unit test 
>
GpuLayerCachec:\0\build\slave\workdir\build\skia\include\private\skuniqueptr.h:164:
> failed assertion "get() != pointer()"
> 
> Caught exception 2147483651 EXCEPTION_BREAKPOINT
> ....

There are still other issues with GpuDrawPath.  Leaving disabled for now, and
adding a more focused oval test instead.

The bots that were failing look good for patch set 2, so I think this is safe to
reland.

[f(malita), 2015-11-19 04:01:07]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2015-11-19 04:01:07]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1457073002/#ps20001
(title: "don't enable GpuDrawPath")

[commit-bot: I haz the power, 2015-11-19 04:01:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457073002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457073002/20001

[commit-bot: I haz the power, 2015-11-19 04:13:02]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/fbe1c110acf218a7b2b5d378a752dc1845816d6e