Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: mojo/services/camera/interfaces/camera.mojom

Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Follow review Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/camera/interfaces/camera.mojom
diff --git a/mojo/services/camera/interfaces/camera.mojom b/mojo/services/camera/interfaces/camera.mojom
index b7cc5cb7184b568bf79d49077baf861a2ca164c5..9f607b07cb0e8b70bc3cf48289d0e1cd50dc9ec5 100644
--- a/mojo/services/camera/interfaces/camera.mojom
+++ b/mojo/services/camera/interfaces/camera.mojom
@@ -18,6 +18,7 @@ struct Photo {
// The camera roll is exposed as a snapshot of all photos available as a list.
// The head of the list (element with index 0) is a photo with the latest
// timestamp and subsequent elements are in decreasing order of timestamp.
+[ServiceName="mojo::CameraRollService"]
interface CameraRollService {
// Updates the snapshot of all photos available. Photos might have been added
// or removed after the service was started or |Update| was called.
@@ -30,6 +31,7 @@ interface CameraRollService {
};
// |CameraService| provides access to the device's camera video stream.
+[ServiceName="mojo::CameraService"]
interface CameraService {
// Returns the most recent frame captured by the device's camera
// in preview mode.

Powered by Google App Engine
This is Rietveld 408576698