mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl - Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl

Issue 1457383005: Require an explicit ServiceName annotation for interfaces in Java (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Follow review Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java ('k') | mojo/services/camera/interfaces/camera.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl

diff --git a/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl b/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl

index 527e15fbfcf5d6d7581a115f22900715a6076717..0aec7fac5d9e80620a47e0e100a760ee564ee8f6 100644

--- a/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl

+++ b/mojo/public/tools/bindings/generators/java_templates/interface_definition.tmpl

@@ -51,16 +51,18 @@ org.chromium.mojo.bindings.MessageHeader.MESSAGE_IS_RESPONSE_FLAG

{%- endmacro -%}

{%- macro manager_class(interface, fully_qualified=False) -%}

-{% if fully_qualified %}org.chromium.mojo.bindings.Interface.{% endif %}Manager<{{interface|name}}, {{interface|name}}.Proxy>

+{% if fully_qualified %}org.chromium.mojo.bindings.Interface.{% endif %}{% if interface.service_name %}Named{% endif %}Manager<{{interface|name}}, {{interface|name}}.Proxy>

{%- endmacro -%}

{%- macro manager_def(interface) -%}

public static final {{manager_class(interface, True)}} MANAGER =

new {{manager_class(interface, True)}}() {

+{% if interface.service_name %}

public String getName() {

- return "{{namespace|replace(".","::")}}::{{interface.name}}";

+ return "{{interface.service_name}}";

}

+{% endif %}

public int getVersion() {

return {{interface.version}};