Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Issue 1457373002: [turbofan] Implemented the TruncateFloat64ToUint64 TurboFan operator. (Closed)

Created:
5 years, 1 month ago by ahaas
Modified:
5 years, 1 month ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com, v8-ppc-ports_googlegroups.com, v8-mips-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implemented the TruncateFloat64ToUint64 TurboFan operator. The TruncateFloat64ToUint64 operator converts a float64 to an uint64 using round-to-zero rounding mode (truncate). If the input value is outside uint64 range, then the result depends on the architecture. I provide an implementation for x64 and arm64. @v8-ppc-ports and @v8-mips-ports, can you do the implementations for ppc64 and mips64? R=titzer@chromium.org Committed: https://crrev.com/f6e689cebbd2de36e2b38474f89b1ad37fbfbb0f Cr-Commit-Position: refs/heads/master@{#32127}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1 line) Patch
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +2 lines, -1 line 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
5 years, 1 month ago (2015-11-19 18:04:15 UTC) #1
titzer
lgtm https://codereview.chromium.org/1457373002/diff/1/src/compiler/x64/code-generator-x64.cc File src/compiler/x64/code-generator-x64.cc (right): https://codereview.chromium.org/1457373002/diff/1/src/compiler/x64/code-generator-x64.cc#newcode1044 src/compiler/x64/code-generator-x64.cc:1044: // input value was not within the positive ...
5 years, 1 month ago (2015-11-19 19:41:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457373002/20001
5 years, 1 month ago (2015-11-19 20:15:34 UTC) #6
ahaas
On 2015/11/19 at 19:41:10, titzer wrote: > lgtm > > https://codereview.chromium.org/1457373002/diff/1/src/compiler/x64/code-generator-x64.cc > File src/compiler/x64/code-generator-x64.cc (right): ...
5 years, 1 month ago (2015-11-19 20:16:23 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-19 20:42:10 UTC) #8
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 20:42:32 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f6e689cebbd2de36e2b38474f89b1ad37fbfbb0f
Cr-Commit-Position: refs/heads/master@{#32127}

Powered by Google App Engine
This is Rietveld 408576698