Aura Android: Add implementation for two factory methods

Aura Android: Add implementation for two factory methods

This CL did the following:
1. implement CreateBrowserNonClientFrameView for AuraAndroid
2. implement CreateImmersiveModeController for AuraAndroid
3. rename browser_non_client_frame_view_factory_aura to browser_non_client_frame_view_factory__ash as it depends on ash
4. gypi file change

BUG=557285
Committed: https://crrev.com/d098d77ded1118e5da65bd091d3a180218373de0
Cr-Commit-Position: refs/heads/master@{#360948}

[bshe, 2015-11-19 20:21:52]

Description was changed from

==========
Rename browser_non_client_frame_view_factory_aura to *_ash and add Android
implementation

browser_non_client_frame_view_factory_aura depends on ash, so it should belong
to ash. For
Aura Android(which set aura but not ash to true), add
browser_non_client_frame_view_factory_android.


BUG=557285
==========

to

==========
Aura Android: Add implementation for two factory methods

This CL did the following:
1. implement CreateBrowserNonClientFrameView for AuraAndroid
2. implement CreateImmersiveModeController for AuraAndroid
3. rename browser_non_client_frame_view_factory_aura to
browser_non_client_frame_view_factory__ash as it depends on ash
4. gn file change


BUG=557285
==========

[bshe, 2015-11-19 20:22:41]

bshe@chromium.org changed reviewers:
+ mfomitchev@chromium.org

[bshe, 2015-11-19 20:22:42]

Hi Mikhail.

Do you mind to take a look at this CL?
Thanks!

[mfomitchev, 2015-11-19 23:31:39]

gn file change -> gypi file change in the description

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_ash.cc
(right):

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_ash.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
fix copyright

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_ash.cc:5:
#include "chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h"
empty line after this

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/immersive_mode_controller_factory_android.cc
(right):

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/immersive_mode_controller_factory_android.cc:12:
return new ImmersiveModeControllerStub();
Perhaps we should create a crbug for adding a real implementation (and add a
TODO here)?

[bshe, 2015-11-20 15:19:25]

Description was changed from

==========
Aura Android: Add implementation for two factory methods

This CL did the following:
1. implement CreateBrowserNonClientFrameView for AuraAndroid
2. implement CreateImmersiveModeController for AuraAndroid
3. rename browser_non_client_frame_view_factory_aura to
browser_non_client_frame_view_factory__ash as it depends on ash
4. gn file change


BUG=557285
==========

to

==========
Aura Android: Add implementation for two factory methods

This CL did the following:
1. implement CreateBrowserNonClientFrameView for AuraAndroid
2. implement CreateImmersiveModeController for AuraAndroid
3. rename browser_non_client_frame_view_factory_aura to
browser_non_client_frame_view_factory__ash as it depends on ash
4. gypi file change


BUG=557285
==========

[bshe, 2015-11-20 17:13:34]

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_ash.cc
(right):

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_ash.cc:1: //
Copyright (c) 2012 The Chromium Authors. All rights reserved.
On 2015/11/19 23:31:38, mfomitchev wrote:
> fix copyright

Done.

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_ash.cc:5:
#include "chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.h"
On 2015/11/19 23:31:38, mfomitchev wrote:
> empty line after this

Done.

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
File chrome/browser/ui/views/frame/immersive_mode_controller_factory_android.cc
(right):

https://codereview.chromium.org/1457353002/diff/40001/chrome/browser/ui/views...
chrome/browser/ui/views/frame/immersive_mode_controller_factory_android.cc:12:
return new ImmersiveModeControllerStub();
On 2015/11/19 23:31:39, mfomitchev wrote:
> Perhaps we should create a crbug for adding a real implementation (and add a
> TODO here)?

Done.

[mfomitchev, 2015-11-20 18:04:56]

LGTM

[bshe, 2015-11-20 18:54:56]

bshe@chromium.org changed reviewers:
+ sky@chromium.org

[bshe, 2015-11-20 18:54:56]

+sky

Thanks!

[sky, 2015-11-20 22:19:11]

LGTM

[bshe, 2015-11-20 22:27:38]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-11-20 22:29:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1457353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1457353002/60001

[commit-bot: I haz the power, 2015-11-20 23:28:19]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-11-20 23:29:23]

Patchset 4 (id:??) landed as
https://crrev.com/d098d77ded1118e5da65bd091d3a180218373de0
Cr-Commit-Position: refs/heads/master@{#360948}