Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java

Issue 1457343002: Instr. test for calling onPageFinished as provisional JS redirect fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Mikhail's comments: naming + add onFailedLoad call count. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
diff --git a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
index d97e1ef9f72e18d4e5706d6dba25f977cfc05192..90ba0087a001e335fd10790176adfee4ca9d475e 100644
--- a/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
+++ b/content/public/test/android/javatests/src/org/chromium/content/browser/test/util/TestCallbackHelperContainer.java
@@ -72,6 +72,21 @@ public class TestCallbackHelperContainer {
}
/**
+ * CallbackHelper for OnFailedLoad.
+ */
+ public static class OnFailedLoadHelper extends CallbackHelper {
+ private String mUrl;
+ public void notifyCalled(String url) {
+ mUrl = url;
+ notifyCalled();
+ }
+ public String getUrl() {
+ assert getCallCount() > 0;
+ return mUrl;
+ }
+ }
+
+ /**
* CallbackHelper for OnPageStarted.
*/
public static class OnPageStartedHelper extends CallbackHelper {

Powered by Google App Engine
This is Rietveld 408576698