android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 1457343002: Instr. test for calling onPageFinished as provisional JS redirect fails

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 1457343002: Instr. test for calling onPageFinished as provisional JS redirect fails (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Mikhail's comments: naming + add onFailedLoad call count. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index 47d0f28fcbfc062b9fd34495ccdc350af712d178..11ad176c467e2fbe44bca6fd5db9b41af318268b 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -334,6 +334,9 @@ public abstract class AwContentsClient {

public abstract void onPageCommitVisible(String url);

+ // Only used for testing

mnaganov (inactive) 2015/12/01 16:42:22 nit: After the rename, this comment is not needed

+ public void onFailedLoadForTesting(String url) {}

public final void onReceivedError(AwWebResourceRequest request, AwWebResourceError error) {

// Only one of these callbacks actually reaches out the client code. The first callback

// is used on API versions up to and including L, the second on subsequent releases.

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java » ('j') | no next file with comments »