Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1457223005: Remove a bunch of Isolate::Current() callsites from simulators (Closed)

Created:
5 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
5 years, 1 month ago
Reviewers:
ulan, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove a bunch of Isolate::Current() callsites from simulators BUG=2487 R=ulan@chromium.org LOG=n Committed: https://crrev.com/c7aace4d43603cc03d90277e7bcf3cc538af1990 Cr-Commit-Position: refs/heads/master@{#32164}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+508 lines, -467 lines) Patch
M src/api.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/arm/simulator-arm.h View 1 2 6 chunks +25 lines, -19 lines 0 comments Download
M src/arm/simulator-arm.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/arm64/simulator-arm64.h View 5 chunks +26 lines, -20 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 1 2 5 chunks +9 lines, -11 lines 0 comments Download
M src/assembler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/execution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/simulator-ia32.h View 3 chunks +9 lines, -4 lines 0 comments Download
M src/mips/simulator-mips.h View 6 chunks +22 lines, -16 lines 0 comments Download
M src/mips/simulator-mips.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/mips64/simulator-mips64.h View 7 chunks +33 lines, -27 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/ppc/simulator-ppc.h View 6 chunks +26 lines, -18 lines 0 comments Download
M src/ppc/simulator-ppc.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M src/regexp/regexp-macro-assembler.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/x64/simulator-x64.h View 1 3 chunks +7 lines, -4 lines 0 comments Download
M src/x87/simulator-x87.h View 1 3 chunks +7 lines, -4 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 2 31 chunks +46 lines, -41 lines 0 comments Download
M test/cctest/test-assembler-mips.cc View 1 2 80 chunks +106 lines, -102 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 1 2 85 chunks +113 lines, -116 lines 0 comments Download
M test/cctest/test-assembler-ppc.cc View 1 2 12 chunks +16 lines, -16 lines 0 comments Download
M test/cctest/test-code-stubs-arm.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-hashing.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-macro-assembler-arm.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 2 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years, 1 month ago (2015-11-20 15:15:20 UTC) #1
Yang
lgtm
5 years, 1 month ago (2015-11-23 07:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1457223005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1457223005/40001
5 years, 1 month ago (2015-11-23 07:49:05 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-23 08:09:42 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 08:10:18 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c7aace4d43603cc03d90277e7bcf3cc538af1990
Cr-Commit-Position: refs/heads/master@{#32164}

Powered by Google App Engine
This is Rietveld 408576698