tools/skpdiff/SkDiffContext.h - Issue 1457123002: Make block size a template parameter of SkTLList

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpdiff/SkDiffContext.h

Issue 1457123002: Make block size a template parameter of SkTLList (Closed) Base URL: https://skia.googlesource.com/skia.git@forward

Patch Set: another missing typename Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpdiff/SkDiffContext.h

diff --git a/tools/skpdiff/SkDiffContext.h b/tools/skpdiff/SkDiffContext.h

index 4a878b872dda2afc9c316886dd11917404186314..863eadedfb73d1ff6cae5d237a8fbe45fbbfff91 100644

--- a/tools/skpdiff/SkDiffContext.h

+++ b/tools/skpdiff/SkDiffContext.h

@@ -188,7 +188,8 @@ private:

// We use linked list for the records so that their pointers remain stable. A resizable array

// might change its pointers, which would make it harder for async diffs to record their

// results.

- SkTLList<DiffRecord> fRecords;

+ typedef SkTLList<DiffRecord, 1> RecordList;

+ RecordList fRecords;

SkImageDiffer** fDiffers;

int fDifferCount;

« no previous file with comments | « tests/LListTest.cpp ('k') | tools/skpdiff/SkDiffContext.cpp » ('j') | no next file with comments »