Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1456973004: [turbofan] Unstable prototype maps are not supported currently. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Unstable prototype maps are not supported currently. We currently assume that all prototype maps are stable, which is not guaranteed for certain keyed access patterns. So we explicitly disallow optimizing the element access there for now. BUG=chromium:557807, v8:4470 R=jarin@chromium.org LOG=n Committed: https://crrev.com/3c9ac974f23cd1fd92f4bc46a2b2bef2c988cf2f Cr-Commit-Position: refs/heads/master@{#32101}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M src/compiler/access-info.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-557807.js View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-19 05:23:34 UTC) #1
Jarin
lgtm
5 years, 1 month ago (2015-11-19 05:26:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1456973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1456973004/1
5 years, 1 month ago (2015-11-19 05:34:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-19 06:20:41 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-19 06:21:13 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c9ac974f23cd1fd92f4bc46a2b2bef2c988cf2f
Cr-Commit-Position: refs/heads/master@{#32101}

Powered by Google App Engine
This is Rietveld 408576698