Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: src/compiler/access-info.cc

Issue 1456973004: [turbofan] Unstable prototype maps are not supported currently. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-557807.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/access-info.cc
diff --git a/src/compiler/access-info.cc b/src/compiler/access-info.cc
index 010689027e8efe89df60a7a7e9d18dcafa1e4ef5..612170e5b1b64a422af12f1356245e97b3a1c4c9 100644
--- a/src/compiler/access-info.cc
+++ b/src/compiler/access-info.cc
@@ -156,6 +156,12 @@ bool AccessInfoFactory::ComputeElementAccessInfo(
Handle<JSReceiver> prototype =
PrototypeIterator::GetCurrent<JSReceiver>(i);
if (!prototype->IsJSObject()) return false;
+ // TODO(bmeurer): We do not currently support unstable prototypes.
+ // We might want to revisit the way we handle certain keyed stores
+ // because this whole prototype chain check is essential a hack,
+ // and I'm not sure that it is correct at all with dictionaries in
+ // the prototype chain.
+ if (!prototype->map()->is_stable()) return false;
holder = Handle<JSObject>::cast(prototype);
}
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-557807.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698