Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2079)

Unified Diff: chrome/browser/ui/browser.h

Issue 1456963002: Make browser windows override_redirect when dragging tabs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser.h
diff --git a/chrome/browser/ui/browser.h b/chrome/browser/ui/browser.h
index 362d85a679987c6b877490bdc4797511cc8a8afe..a8d7b866f221289cf4413807f426a6eff1407857 100644
--- a/chrome/browser/ui/browser.h
+++ b/chrome/browser/ui/browser.h
@@ -194,6 +194,8 @@ class Browser : public TabStripModelObserver,
// default. Intended for testing.
BrowserWindow* window;
+ bool override_redirect;
Daniel Erat 2015/11/18 16:16:47 this should be desktop-linux-only. i _think_ that
Elliot Glaysher 2015/11/18 18:20:21 It's: #if defined(OS_LINUX) && !defined(OS_CHROME
stapelberg 2015/12/23 13:17:24 Done.
+
private:
friend class Browser;
@@ -465,6 +467,8 @@ class Browser : public TabStripModelObserver,
bool is_type_tabbed() const { return type_ == TYPE_TABBED; }
bool is_type_popup() const { return type_ == TYPE_POPUP; }
+ bool is_override_redirect() const { return override_redirect_; }
+
bool is_app() const;
bool is_devtools() const;
@@ -847,6 +851,7 @@ class Browser : public TabStripModelObserver,
// This Browser's type.
const Type type_;
+
// This Browser's profile.
Profile* const profile_;
@@ -969,6 +974,8 @@ class Browser : public TabStripModelObserver,
scoped_ptr<ValidationMessageBubble> validation_message_bubble_;
+ bool override_redirect_;
+
// The following factory is used for chrome update coalescing.
base::WeakPtrFactory<Browser> chrome_updater_factory_;

Powered by Google App Engine
This is Rietveld 408576698