Make browser windows override_redirect when dragging tabs.

chrome/browser/ui/browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 176 matching lines @@
     gfx::Rect initial_bounds;
 
     ui::WindowShowState initial_show_state;
 
     bool is_session_restore;
 
     // Supply a custom BrowserWindow implementation, to be used instead of the
     // default. Intended for testing.
     BrowserWindow* window;
 
+    bool override_redirect;

[Daniel Erat, 2015/11/18 16:16:47]

this should be desktop-linux-only. i _think_ that the way to detect that is:

  #if !defined(OS_CHROMEOS) && defined(USE_X11)

but i'm also wondering if is_dragged_tab or something similar would be more
appropriate. are there any cases where we'd have an override-redirect browser
otherwise?

[Elliot Glaysher, 2015/11/18 18:20:21]

It's:

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

[stapelberg, 2015/12/23 13:17:24]

Done.

+
    private:
     friend class Browser;
 
     // The application name that is also the name of the window to the shell.
     // Do not set this value directly, use CreateForApp.
     // This name will be set for:
     // 1) v1 applications launched via an application shortcut or extension API.
     // 2) undocked devtool windows.
     // 3) popup windows spawned from v1 applications.
     std::string app_name;
@@ skipping 251 matching lines @@
   bool CanDragEnter(content::WebContents* source,
                     const content::DropData& data,
                     blink::WebDragOperationsMask operations_allowed) override;
   content::SecurityStyle GetSecurityStyle(
       content::WebContents* web_contents,
       content::SecurityStyleExplanations* security_style_explanations) override;
 
   bool is_type_tabbed() const { return type_ == TYPE_TABBED; }
   bool is_type_popup() const { return type_ == TYPE_POPUP; }
 
+  bool is_override_redirect() const { return override_redirect_; }
+
   bool is_app() const;
   bool is_devtools() const;
 
   // True when the mouse cursor is locked.
   bool IsMouseLocked() const;
 
   // Called each time the browser window is shown.
   void OnWindowDidShow();
 
   // Show the first run search engine bubble on the location bar.
@@ skipping 362 matching lines @@
   ScopedObserver<extensions::ExtensionRegistry,
                  extensions::ExtensionRegistryObserver>
       extension_registry_observer_;
 #endif
 
   PrefChangeRegistrar profile_pref_registrar_;
 
   // This Browser's type.
   const Type type_;
 
+
   // This Browser's profile.
   Profile* const profile_;
 
   // This Browser's window.
   BrowserWindow* window_;
 
   scoped_ptr<TabStripModelDelegate> tab_strip_model_delegate_;
   scoped_ptr<TabStripModel> tab_strip_model_;
 
   // The application name that is also the name of the window to the shell.
@@ skipping 102 matching lines @@
 
   scoped_ptr<extensions::WindowController> extension_window_controller_;
 
   scoped_ptr<chrome::BrowserCommandController> command_controller_;
 
   // True if the browser window has been shown at least once.
   bool window_has_shown_;
 
   scoped_ptr<ValidationMessageBubble> validation_message_bubble_;
 
+  bool override_redirect_;
+
   // The following factory is used for chrome update coalescing.
   base::WeakPtrFactory<Browser> chrome_updater_factory_;
 
   // The following factory is used to close the frame at a later time.
   base::WeakPtrFactory<Browser> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_